github.com - > gitlab.com - > git.wanhose.dev #138
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No Assignees
7 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wanhose/cookie-dialog-monster#138
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hi, @wanhose
Time to move the discussion here to this new repository.
I have read several of your comments here https://gitlab.com/wanhose/cookie-dialog-monster/-/issues/1 and you have my support, you have my trust and I have trust in your excellent extension which you are constantly improving and if we have a problem - that's why we alert through your extension, indicating a problem site. It's that easy.
I give you my thanks and I noticed that two days you spent many hours on github.com -> gitlab.com -> git.wanhose.dev to port everything and your work was colossal.
Go ahead on your part and we follow you as a developer.
Hi @Rusenche,
Thank you so much for the support! Hearing that you trust the extension means a lot. The migration was a big task, but it's all worth it knowing the project is making a difference. I'll keep up the improvements, and your feedback is always welcome.
Thanks again for being part of this!
Thanks so much @wanhose for your amazing work to keep this great project alive! I was so disgusted by GitHub's behaviour here that I wrote a thread about it: https://x.com/adamspiers/status/1846869956350058853
Hello,
If I could also chime in with a question:
Regarding the "Youtube thing", the user "cremor" wrote here:
Here https://gitlab.com/wanhose/cookie-dialog-monster/-/issues/1#note_2156500257 you "answered":
A redirect to a specific video including channel subscription... I mean this without any accusation (really!) - how is that possible?
Is there a chance that the expansion will find its way back to AMO?
Thank you and greetings!
Martin
Hi @aspiers,
I'm really happy to see you around this repository again. Thanks for your kind words, I really appreciate it man. It's been hard to see all my work from the past 5 years gone from the face of the Earth. I'm too disappointed because there's still no response from GitHub, by the way.
That being said, your support means a lot to me, and it's what keeps the project alive. I'll keep pushing forward, and hopefully, we'll find a resolution soon. Thanks again!
Hi @m.fessler,
First of all, welcome to the repository! Thank you for continuing the conversation here. I'll try to explain the situation, although it can be a bit tricky to understand.
Let me start by saying that it's crucial to download the extension only from trusted sources, like the official browser stores or this repository. For example, Softonic has somehow posted the extension without permission, and I can't guarantee what they've done with it, or if they’ve modified it in any way. So please, only download the extension from this repository, the official website, or the official browser stores.
Now, on to the issue you're mentioning. Recently, I made some changes to how we hide elements on the page. You can see an example below:
I used a somewhat unconventional approach to avoid conflicts with other CSS properties that were overwriting our changes to hide them, but it turned out not to be the best solution. Some elements had inline styles, like this:
This caused issues, particularly on YouTube. Although GitHub has hidden the repository, the problem started in version 7.2.4 and was fixed in 7.3.1 once I tracked it down.
Regarding the subscription issue, no one (including @cremor) has ever mentioned it before. It would've been helpful to have that detail included in the issue earlier, but that's another topic for discussion.
Even though I applied my own style rules, the dialog was invisible but was there like transparent. This issue likely connects to another part of the code, where we handle clicking buttons in dialogs (usually the "decline" button). You can check out the sites that were manually handled here. Even if you're not familiar with code, you'll see it's about resetting properties and clicking buttons.
Now, about the subscription thing. While I haven't experienced this myself, and no one has reported it before, it's possible that the extension clicked too quickly and accidentally hit the subscribe button. It could be a rare coincidence, but I'm not ruling it out.
If the extension hid the dialog but the buttons stayed in place, the click might have propagated to the button behind the hidden one. Depending on your screen size or if you scrolled, that button could've been the progress bar or the subscribe button, as shown in the image.
So, in conclusion, this was an unfortunate coincidence, not some intentional malicious action. The extension has always been open-source, and it has been reviewed by both Chrome and Firefox teams before being published. The chance of it intentionally subscribing you to random channels is essentially zero.
Finally, I've had issues with my AMO account due to 2FA and couldn't recover it despite having an extension with a small user base. I suggest downloading the
.xpifile from the binaries page or from our website for automatic updates, just like you would if it were installed from the store. Also, feel free to check out the wiki here, where I've added guides and answered common questions.Sorry about the inconveniences, but I'm NOT doing evil stuff.
Thanks for the detailed answer!
About not mentioning the automatic subscription before: I only noticed that I've been subscribed to that channel after you already had released the fixed addon version. I didn't post it on GitHub because I thought that it wouldn't have provided any value for an already fixed issue. But then it became relevant again for the question in https://github.com/OhMyGuus/I-Still-Dont-Care-About-Cookies/issues/10278#issuecomment-2408947377
To be clear: I never suspected that you had any bad intentions with the addon. I just provided that information as a possible reason why someone might have reported you. But maybe it was completely unrelated to your GitHub issues.
Hi @cremor,
Hope this helps clear things up. It was really just an unfortunate series of coincidences. It doesn't make sense to subscribe you to a random channel, for what reason? This project was, is, and always will be, focused on improving your browsing experience and privacy.
Thanks for bringing it up and letting me explain. I'm always here for the community, so feel free to reach out if you have any questions!
Out of couriosity:
How could you import the issues from GitHub to GitLab when GitHub has blocked your account and has hidden the project (so that it also was not accessible without login)?
Regards!
And another question:
I see that (on Firefox) having installed addon version 7.3.2 triggers an auto-update to 8.0.x -- The 7.3.2 was on github, which is not reachable now. How can it find out that there is the new version?
Hi @fantrousers,
My Github Account have been flagged because they believe I'm violating their conduct restrictions. My account wasn't removed, it's hidden indefinitely but I can access with my credentials. More than 3 weeks since they flagged my account, no answer yet. Shame on GitHub!
Hi again @fantrousers,
Our releases are hosted on
www.cookie-dialog-monster.com/releases/x.x.x(-mozilla-mobile).(xpi|zip), not directly on GitHub. While we previously attached release files to each GitHub release for easy access, the add-on itself has always checked our website for updates, not GitHub. With automatic updates now in place, manually hosting files on GitHub is mostly redundant, but we may still do so for transparency.If you ask for the file that Mozilla Firefox uses to check if there was an update, it's this one for desktop or this one for mobile.
Hi everyone,
After exactly one month, we did it... we're back on GitHub. But it's a bit too late. I've made the final decision to host everything on my own self-hosted Git instance to prevent future issues like this. I'll update the old repository to make it clear.
Thank you all for your incredible support and patience throughout this journey. It's been a long road, but we came through together.
Did GitHub provide any reason why they did hide your account?
And, when you write "we're back", whom do you refer to by "we" (not "I")?
Regards!
GitHub provided a pretty generic response, as you can see. They just cited some vague policy violations without giving any specific details or addressing the actual issues I raised.
As for "we," that refers to me, my account, and the project—basically, everything I've put my time and effort into that's been affected by this.
@wanhose, much appreciation for your patience. 🎉.
What appalling behaviour from GitHub. They didn't even apologise?!
Getting my account unblocked seems to be the best I can expect. What I hadn't mentioned yet is that this all happened right in the middle of a job search—hundreds of applications with links to my portfolio, projects, and more on GitHub, all leading to 404 errors. Who knows how many rejections that might have caused? Can we even calculate the real damage done this time?
Hey. I'm coming from Guus' thread on GitHub, and created a account here just to say: Thank You. Thank you wanhose and thank you Guus for making these amazing browser extensions.
Your resilience and love to maintain something useful admires me and gives me strength for stuffs i do. <3
Wow, @denny, your comment seriously made my day. It's not always easy, but knowing that what we're doing makes a difference for someone makes it all so worth it. Thank you for taking the time to share that because it really means a lot ❤️
Wishing you all the best with whatever you're working on, and if you ever feel like jumping in and helping out here, the door's always open. We're all in this together!
Keep going my friend 🚀
Left a feedback at Mozilla's Firefox addon site.
Ahoj @wanhose,
appreciating your work, I am wondering if you just take a break now for some time, or if you just cannot keep up anymore with maintaining this project?
I see that the last stuff happened here is ~1 month ago, and that is a big "break" from the previously very quick response and development. That's why I am asking, not pressing you, just to know.
Regards!
Hey @fantrousers,
Just doing some behind-the-scenes maintainer stuff since the project's in a really solid place. I'm job hunting right now, so once I find something, I'll jump back into more active development.
Wishing you the best this year!