From 1ac4812ebf310e7463ef6111c4a50e1f0fe0c03a Mon Sep 17 00:00:00 2001 From: wanhose Date: Sat, 19 Oct 2024 18:23:25 +0200 Subject: [PATCH 1/5] chore(browser-extension): bump extension version --- packages/browser-extension/src/manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/browser-extension/src/manifest.json b/packages/browser-extension/src/manifest.json index cdde134..e29441c 100644 --- a/packages/browser-extension/src/manifest.json +++ b/packages/browser-extension/src/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 3, "name": "Cookie Dialog Monster", - "version": "8.0.2", + "version": "8.0.3", "default_locale": "en", "description": "__MSG_appDesc__", "icons": { -- 2.45.2 From 6b788abe28e30ef15e1a295a451e63ba36b40d5f Mon Sep 17 00:00:00 2001 From: wanhose Date: Sat, 19 Oct 2024 18:23:47 +0200 Subject: [PATCH 2/5] refactor(browser-extension): drop old github references --- packages/browser-extension/src/_locales/de/messages.json | 4 ++-- packages/browser-extension/src/_locales/en/messages.json | 4 ++-- packages/browser-extension/src/_locales/es/messages.json | 4 ++-- packages/browser-extension/src/_locales/fr/messages.json | 4 ++-- packages/browser-extension/src/_locales/it/messages.json | 4 ++-- packages/browser-extension/src/_locales/pl/messages.json | 4 ++-- packages/browser-extension/src/_locales/pt_BR/messages.json | 4 ++-- packages/browser-extension/src/_locales/pt_PT/messages.json | 4 ++-- packages/browser-extension/src/_locales/ro/messages.json | 4 ++-- packages/browser-extension/src/_locales/ru/messages.json | 4 ++-- 10 files changed, 20 insertions(+), 20 deletions(-) diff --git a/packages/browser-extension/src/_locales/de/messages.json b/packages/browser-extension/src/_locales/de/messages.json index 3ba2a3a..bab0c60 100644 --- a/packages/browser-extension/src/_locales/de/messages.json +++ b/packages/browser-extension/src/_locales/de/messages.json @@ -3,7 +3,7 @@ "message": "Hat jemand Cookie-Einwilligungsdialoge gesagt? 😋" }, "contextMenu_issueOption": { - "message": "Folgen Sie diesem Problem auf GitHub" + "message": "Folgen Sie diesem Problem" }, "contextMenu_reportOption": { "message": "Diese Website melden" @@ -57,7 +57,7 @@ "message": "Bewerten Sie diese Erweiterung" }, "report_bodyText": { - "message": "Bitte geben Sie in diesem Bericht keine persönlichen Informationen weiter. Wenn Sie weitere Details hinzufügen möchten, öffnen Sie das GitHub-Problem im nächsten Schritt und fügen Sie einen Kommentar hinzu." + "message": "Bitte teilen Sie in diesem Bericht keine persönlichen Informationen. Wenn Sie weitere Details hinzufügen möchten, gehen Sie im nächsten Schritt zum Problem und fügen Sie einen Kommentar hinzu." }, "report_cancelButtonText": { "message": "Abbrechen" diff --git a/packages/browser-extension/src/_locales/en/messages.json b/packages/browser-extension/src/_locales/en/messages.json index 9a23090..bad3e9c 100644 --- a/packages/browser-extension/src/_locales/en/messages.json +++ b/packages/browser-extension/src/_locales/en/messages.json @@ -3,7 +3,7 @@ "message": "Did someone say cookie consent dialogs? 😋" }, "contextMenu_issueOption": { - "message": "Follow this issue in GitHub" + "message": "Follow this issue" }, "contextMenu_reportOption": { "message": "Report this website" @@ -57,7 +57,7 @@ "message": "Rate this extension" }, "report_bodyText": { - "message": "Please, do not share any personal information in this report. If you want to add more details, open the GitHub issue in the next step and add a comment." + "message": "Please, do not share any personal information in this report. If you want to add more details, go to the issue in the next step and add a comment." }, "report_cancelButtonText": { "message": "Cancel" diff --git a/packages/browser-extension/src/_locales/es/messages.json b/packages/browser-extension/src/_locales/es/messages.json index 197d909..c7bff92 100644 --- a/packages/browser-extension/src/_locales/es/messages.json +++ b/packages/browser-extension/src/_locales/es/messages.json @@ -3,7 +3,7 @@ "message": "¿Alguien mencionó los diálogos de consentimiento de cookies? 😋" }, "contextMenu_issueOption": { - "message": "Sigue este problema en GitHub" + "message": "Sigue este problema" }, "contextMenu_reportOption": { "message": "Reportar este sitio web" @@ -57,7 +57,7 @@ "message": "Califica esta extensión" }, "report_bodyText": { - "message": "Por favor, no compartas ninguna información personal en este informe. Si deseas agregar más detalles, abre el problema de GitHub en el siguiente paso y agrega un comentario." + "message": "Por favor, no compartas información personal en este informe. Si deseas agregar más detalles, ve al problema en el siguiente paso y añade un comentario." }, "report_cancelButtonText": { "message": "Cancelar" diff --git a/packages/browser-extension/src/_locales/fr/messages.json b/packages/browser-extension/src/_locales/fr/messages.json index af717a3..74dcfba 100644 --- a/packages/browser-extension/src/_locales/fr/messages.json +++ b/packages/browser-extension/src/_locales/fr/messages.json @@ -3,7 +3,7 @@ "message": "Quelqu'un a parlé de boîtes de dialogue de consentement aux cookies ? 😋" }, "contextMenu_issueOption": { - "message": "Suivre ce problème sur GitHub" + "message": "Suivre ce problème" }, "contextMenu_reportOption": { "message": "Signaler ce site web" @@ -57,7 +57,7 @@ "message": "Évaluer cette extension" }, "report_bodyText": { - "message": "Veuillez ne pas partager d'informations personnelles dans ce rapport. Si vous souhaitez ajouter plus de détails, ouvrez le problème GitHub à l'étape suivante et ajoutez un commentaire." + "message": "Veuillez ne partager aucune information personnelle dans ce rapport. Si vous souhaitez ajouter plus de détails, allez à l'issue à l'étape suivante et ajoutez un commentaire." }, "report_cancelButtonText": { "message": "Annuler" diff --git a/packages/browser-extension/src/_locales/it/messages.json b/packages/browser-extension/src/_locales/it/messages.json index 26d5ee2..744d42e 100644 --- a/packages/browser-extension/src/_locales/it/messages.json +++ b/packages/browser-extension/src/_locales/it/messages.json @@ -3,7 +3,7 @@ "message": "Qualcuno ha parlato di dialoghi di consenso sui cookie? 😋" }, "contextMenu_issueOption": { - "message": "Segui questo problema su GitHub" + "message": "Segui questo problema" }, "contextMenu_reportOption": { "message": "Segnala questo sito web" @@ -57,7 +57,7 @@ "message": "Valuta questa estensione" }, "report_bodyText": { - "message": "Per favore, non condividere informazioni personali in questo rapporto. Se vuoi aggiungere più dettagli, apri il problema su GitHub nel passaggio successivo e aggiungi un commento." + "message": "Per favore, non condividere informazioni personali in questo rapporto. Se desideri aggiungere ulteriori dettagli, vai al problema nel prossimo passaggio e aggiungi un commento." }, "report_cancelButtonText": { "message": "Annulla" diff --git a/packages/browser-extension/src/_locales/pl/messages.json b/packages/browser-extension/src/_locales/pl/messages.json index 228e156..4a0eb7d 100644 --- a/packages/browser-extension/src/_locales/pl/messages.json +++ b/packages/browser-extension/src/_locales/pl/messages.json @@ -3,7 +3,7 @@ "message": "Czy ktoś wspomniał o dialogach zgody na pliki cookie? 😋" }, "contextMenu_issueOption": { - "message": "Śledź ten problem na GitHub" + "message": "Śledź ten problem" }, "contextMenu_reportOption": { "message": "Zgłoś tę stronę" @@ -57,7 +57,7 @@ "message": "Oceń to rozszerzenie" }, "report_bodyText": { - "message": "Prosimy, nie udostępniaj żadnych danych osobowych w tym raporcie. Jeśli chcesz dodać więcej szczegółów, otwórz zgłoszenie na GitHub w następnym kroku i dodaj komentarz." + "message": "Proszę, nie udostępniaj żadnych danych osobowych w tym raporcie. Jeśli chcesz dodać więcej szczegółów, przejdź do zgłoszenia w kolejnym kroku i dodaj komentarz." }, "report_cancelButtonText": { "message": "Anuluj" diff --git a/packages/browser-extension/src/_locales/pt_BR/messages.json b/packages/browser-extension/src/_locales/pt_BR/messages.json index 09e96a2..e276722 100644 --- a/packages/browser-extension/src/_locales/pt_BR/messages.json +++ b/packages/browser-extension/src/_locales/pt_BR/messages.json @@ -3,7 +3,7 @@ "message": "Alguém falou sobre diálogos de consentimento de cookies? 😋" }, "contextMenu_issueOption": { - "message": "Siga este problema no GitHub" + "message": "Siga este problema" }, "contextMenu_reportOption": { "message": "Denunciar este site" @@ -57,7 +57,7 @@ "message": "Avalie esta extensão" }, "report_bodyText": { - "message": "Por favor, não compartilhe nenhuma informação pessoal neste relatório. Se você quiser adicionar mais detalhes, abra o problema no GitHub na próxima etapa e adicione um comentário." + "message": "Por favor, não compartilhe informações pessoais neste relatório. Se quiser adicionar mais detalhes, vá até o problema no próximo passo e adicione um comentário." }, "report_cancelButtonText": { "message": "Cancelar" diff --git a/packages/browser-extension/src/_locales/pt_PT/messages.json b/packages/browser-extension/src/_locales/pt_PT/messages.json index d1560eb..324bd5a 100644 --- a/packages/browser-extension/src/_locales/pt_PT/messages.json +++ b/packages/browser-extension/src/_locales/pt_PT/messages.json @@ -3,7 +3,7 @@ "message": "Alguém mencionou diálogos de consentimento de cookies? 😋" }, "contextMenu_issueOption": { - "message": "Siga este problema no GitHub" + "message": "Siga este problema" }, "contextMenu_reportOption": { "message": "Reportar este site" @@ -57,7 +57,7 @@ "message": "Avalie esta extensão" }, "report_bodyText": { - "message": "Por favor, não partilhe nenhuma informação pessoal neste relatório. Se quiser adicionar mais detalhes, abra o problema no GitHub na próxima etapa e adicione um comentário." + "message": "Por favor, não partilhe informações pessoais neste relatório. Se quiser adicionar mais detalhes, vá até ao problema no próximo passo e adicione um comentário." }, "report_cancelButtonText": { "message": "Cancelar" diff --git a/packages/browser-extension/src/_locales/ro/messages.json b/packages/browser-extension/src/_locales/ro/messages.json index 643bcdc..ff7e036 100644 --- a/packages/browser-extension/src/_locales/ro/messages.json +++ b/packages/browser-extension/src/_locales/ro/messages.json @@ -3,7 +3,7 @@ "message": "A menționat cineva dialogurile de consimțământ pentru cookie-uri? 😋" }, "contextMenu_issueOption": { - "message": "Urmărește această problemă pe GitHub" + "message": "Urmărește această problemă" }, "contextMenu_reportOption": { "message": "Raportează acest site web" @@ -57,7 +57,7 @@ "message": "Evaluează această extensie" }, "report_bodyText": { - "message": "Te rugăm să nu împărtășești informații personale în acest raport. Dacă dorești să adaugi mai multe detalii, deschide problema GitHub în pasul următor și adaugă un comentariu." + "message": "Vă rugăm să nu împărtășiți informații personale în acest raport. Dacă doriți să adăugați mai multe detalii, accesați problema în pasul următor și adăugați un comentariu." }, "report_cancelButtonText": { "message": "Anulează" diff --git a/packages/browser-extension/src/_locales/ru/messages.json b/packages/browser-extension/src/_locales/ru/messages.json index eb985ec..f5122d5 100644 --- a/packages/browser-extension/src/_locales/ru/messages.json +++ b/packages/browser-extension/src/_locales/ru/messages.json @@ -3,7 +3,7 @@ "message": "Кто-то сказал диалоги согласия на использование cookie? 😋" }, "contextMenu_issueOption": { - "message": "Следить за этим вопросом на GitHub" + "message": "Следить за этой проблемой" }, "contextMenu_reportOption": { "message": "Сообщить об этом сайте" @@ -57,7 +57,7 @@ "message": "Оцените это расширение" }, "report_bodyText": { - "message": "Пожалуйста, не делитесь личной информацией в этом отчете. Если вы хотите добавить больше деталей, откройте вопрос на GitHub на следующем шаге и добавьте комментарий." + "message": "Пожалуйста, не делитесь личной информацией в этом отчете. Если вы хотите добавить больше деталей, перейдите к проблеме на следующем этапе и добавьте комментарий." }, "report_cancelButtonText": { "message": "Отмена" -- 2.45.2 From fd19ba324213f0e2728f4c65fd713a460b0ccb73 Mon Sep 17 00:00:00 2001 From: wanhose Date: Sat, 19 Oct 2024 18:29:03 +0200 Subject: [PATCH 3/5] refactor(browser-extension): drop unnecessary line break --- packages/browser-extension/src/scripts/background.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/browser-extension/src/scripts/background.js b/packages/browser-extension/src/scripts/background.js index f51a736..17698b4 100644 --- a/packages/browser-extension/src/scripts/background.js +++ b/packages/browser-extension/src/scripts/background.js @@ -338,7 +338,6 @@ browser.runtime.onMessage.addListener((message, sender, callback) => { case 'REPORT': report(message).then(callback); return true; - case 'UPDATE_BADGE': if (isPage && tabId !== undefined) { browser.action.setBadgeBackgroundColor({ color: '#6b7280' }); -- 2.45.2 From 9293bd84acda55999a37db6866e3091ed0001298 Mon Sep 17 00:00:00 2001 From: wanhose Date: Mon, 28 Oct 2024 12:21:38 +0100 Subject: [PATCH 4/5] fix(browser-extension): some broken styles in firefox --- packages/browser-extension/src/popup.html | 4 +-- .../browser-extension/src/styles/popup.css | 31 +++++++++---------- 2 files changed, 16 insertions(+), 19 deletions(-) diff --git a/packages/browser-extension/src/popup.html b/packages/browser-extension/src/popup.html index afd0901..c745037 100644 --- a/packages/browser-extension/src/popup.html +++ b/packages/browser-extension/src/popup.html @@ -178,7 +178,7 @@ - + - + diff --git a/packages/browser-extension/src/styles/popup.css b/packages/browser-extension/src/styles/popup.css index 014ebe4..3ffa7b7 100644 --- a/packages/browser-extension/src/styles/popup.css +++ b/packages/browser-extension/src/styles/popup.css @@ -23,6 +23,7 @@ body { body * { box-sizing: border-box; + font-family: Inter, Arial, Helvetica, sans-serif; } button { @@ -89,6 +90,8 @@ header { } main > .banner { + font-size: 14px; + line-height: 18px; margin: 0px; padding: 16px; @@ -126,6 +129,7 @@ popup-button { cursor: pointer; display: grid; font-size: 14px; + line-height: 18px; gap: 16px; grid-template-rows: repeat(2, 1fr); height: 136px; @@ -167,6 +171,7 @@ popup-data:not(:first-child) { popup-data-button { cursor: pointer; + line-height: 0; outline: none; transition: 0.4s; } @@ -194,13 +199,13 @@ popup-data-container { font-size: 12px; grid-column: 1 / -1; justify-self: center; + line-height: 16px; text-align: center; } .report { - font-family: inherit; font-size: 14px; - line-height: 1.2; + line-height: 18px; padding: 16px; & .report-buttons { @@ -228,7 +233,6 @@ popup-data-container { border-radius: 4px; color: var(--color-secondary); cursor: text; - font-family: Inter, Arial, Helvetica, sans-serif; font-size: 14px; line-height: 1; outline: none; @@ -279,9 +283,8 @@ popup-data-container { & .report-input-error { color: var(--color-error); display: none; - font-family: Inter, Arial, Helvetica, sans-serif; font-size: 10px; - line-height: 1.2; + line-height: 14px; } & .report-input-group { @@ -291,9 +294,8 @@ popup-data-container { & .report-input-label { color: var(--color-secondary); - font-family: Inter, Arial, Helvetica, sans-serif; font-size: 12px; - line-height: 1.2; + line-height: 16px; } & .report-input-label-required { @@ -306,10 +308,9 @@ popup-data-container { color: var(--color-secondary); cursor: pointer; display: flex; - font-family: Inter, Arial, Helvetica, sans-serif; font-size: 14px; justify-content: center; - line-height: 1.2; + line-height: 18px; margin-left: auto; margin-right: auto; margin-top: 16px; @@ -332,11 +333,10 @@ popup-data-container { color: var(--color-white); cursor: pointer; display: flex; - font-family: Inter, Arial, Helvetica, sans-serif; font-size: 14px; height: 42px; justify-content: center; - line-height: 1.2; + line-height: 18px; margin-top: 8px; outline: none; padding: 8px 16px; @@ -367,17 +367,15 @@ popup-data-container { } & .report-submit-extra-text { - font-family: inherit; font-size: 14px; - line-height: 1.2; + line-height: 18px; margin: 0px; text-align: justify; } & .report-submit-text { - font-family: inherit; font-size: 18px; - line-height: 1.2; + line-height: 22px; margin: 0px; text-align: center; } @@ -387,7 +385,6 @@ popup-data-container { align-items: center; display: flex; flex-direction: column; - font-family: Inter, Arial, Helvetica, sans-serif; gap: 24px; justify-content: center; margin-top: 16px; @@ -399,7 +396,7 @@ popup-data-container { } } -strong { +b { font-weight: bold; } -- 2.45.2 From 031f7d0b34912c20798441222f3f2d008459f6ba Mon Sep 17 00:00:00 2001 From: wanhose Date: Mon, 28 Oct 2024 12:21:50 +0100 Subject: [PATCH 5/5] fix(browser-extension): issue #166 --- packages/browser-extension/src/scripts/background.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/browser-extension/src/scripts/background.js b/packages/browser-extension/src/scripts/background.js index 17698b4..d02c509 100644 --- a/packages/browser-extension/src/scripts/background.js +++ b/packages/browser-extension/src/scripts/background.js @@ -389,10 +389,8 @@ browser.runtime.onInstalled.addListener((details) => { suppressLastError ); - if (details.reason === 'update') { - refreshData(); - storage.remove('updateAvailable'); - } + if (details.reason === 'update') refreshData(); + storage.remove('updateAvailable'); }); /** -- 2.45.2