From ff1f62e16cdd823492b55f839c2eb06049a6d0f4 Mon Sep 17 00:00:00 2001 From: wanhose Date: Sun, 24 May 2020 20:00:38 +0200 Subject: [PATCH] feat(constants): add untouchable sites to avoid fixing html element --- src/js/modules/constants.js | 3 +++ src/js/modules/helpers.js | 3 ++- src/js/modules/script.js | 9 +++++---- 3 files changed, 10 insertions(+), 5 deletions(-) create mode 100644 src/js/modules/constants.js diff --git a/src/js/modules/constants.js b/src/js/modules/constants.js new file mode 100644 index 0000000..9c81a15 --- /dev/null +++ b/src/js/modules/constants.js @@ -0,0 +1,3 @@ +export const UNTOUCHABLE_SITES = [ + 'www.aviva.co.uk', +]; \ No newline at end of file diff --git a/src/js/modules/helpers.js b/src/js/modules/helpers.js index 9d1c1c4..97b978f 100644 --- a/src/js/modules/helpers.js +++ b/src/js/modules/helpers.js @@ -197,6 +197,7 @@ export const getRemovableElements = (document) => Array.from([ document.querySelector('[data-gdpr-single-choice-overlay]'), document.querySelector('[data-id="cookie-policy"]'), ...document.getElementsByClassName('dimmed'), + document.getElementById('div_bar_cookies_info'), document.getElementById('eu-cookie-law'), ...document.getElementsByClassName('eupopup-container'), document.getElementById('footer_tc_privacy'), @@ -239,4 +240,4 @@ export const getRemovableElements = (document) => Array.from([ document.getElementById('userConsent'), ...document.getElementsByClassName('widget_cookies'), document.getElementById('widget_eu_cookie_law_widget'), -]); \ No newline at end of file +]); diff --git a/src/js/modules/script.js b/src/js/modules/script.js index e110c42..824c756 100644 --- a/src/js/modules/script.js +++ b/src/js/modules/script.js @@ -1,3 +1,4 @@ +import { UNTOUCHABLE_SITES } from './constants.js' import { getNotRemovableElements, getRemovableElements } from './helpers.js'; // Observer @@ -18,9 +19,9 @@ const doMagic = () => { .filter(element => !!element); // Fixing main elements - document.documentElement.style.setProperty('overflow', 'auto', 'important'); - document.documentElement.style.setProperty('overflowX', 'auto', 'important'); - document.documentElement.style.setProperty('overflowY', 'auto', 'important'); + if (!UNTOUCHABLE_SITES.includes(document.location.host)) { + document.documentElement.style.setProperty('overflow', 'unset', 'important'); + } // Remove irritating all removable elements removable.forEach(element => { @@ -35,7 +36,7 @@ const doMagic = () => { // Remove irritating styles from elements not removable notRemovable.forEach(element => { element.style.setProperty('margin-top', 'unset', 'important'); - element.style.setProperty('overflow', 'auto', 'important'); + element.style.setProperty('overflow', 'unset', 'important'); // Miscellaneous element.classList.remove('cli-barmodal-open');