wanhose/cookie-dialog-monster
wanhose/cookie-dialog-monster
2
5
Fork 0
Code Issues 304 Pull Requests Releases 18 Wiki Activity

fix(browser-extension): bad performance when parent updates but its children weren't checked

Browse Source
This commit is contained in:
wanhose 2024-08-10 09:52:29 +02:00
parent c017a298d3
commit a7e1ddfba9
1 changed files with 44 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
packages/browser-extension/src/scripts/content.js
View File

@ -140,13 +140,22 @@ function clean(elements, skipMatch) {
requestAnimationFrame(chunk); requestAnimationFrame(chunk);
} }
/**
* @description Check if element contains a common word
* @param {HTMLElement} element
*/
function containsCommonWord(element) {
return !!element.outerHTML.match(new RegExp(commonWords.join('|')));
}
/** /**
* @description Force a DOM clean in the specific element * @description Force a DOM clean in the specific element
* @param {HTMLElement} element * @param {HTMLElement} element
* @returns {void} * @returns {void}
*/ */
function forceClean(element) { function forceClean(element) {
const elements = [...element.querySelectorAll(tokens.selectors)]; const nodes = [...element.querySelectorAll(tokens.selectors)];
const elements = nodes.flatMap((node) => filterMapEarly(node));
if (elements.length) { if (elements.length) {
fix(); fix();
@ -262,15 +271,29 @@ function match(element, skipMatch) {
(skipMatch || element.matches(tokens.selectors)) (skipMatch || element.matches(tokens.selectors))
); );
} else { } else {
// 2023-06-10: fix edge case force cleaning on children if no attributes
if (commonWords && element.outerHTML.match(new RegExp(commonWords.join('|')))) {
forceClean(element); forceClean(element);
} }
}
return false; return false;
} }
/**
* @description Filter early nodes
* @param {Node} node
* @param {boolean} stopRecursion
*/
function filterMapEarly(node, stopRecursion) {
if (node.nodeType !== Node.ELEMENT_NODE || !(node instanceof HTMLElement)) {
return [];
}
if (commonWords && containsCommonWord(node) && !stopRecursion) {
return [node, ...[...node.children].flatMap((node) => filterMapEarly(node, true))];
}
return [node];
}
/** /**
* @description Fix data, middle consent page and scroll issues * @description Fix data, middle consent page and scroll issues
* @returns {void} * @returns {void}
@ -400,7 +423,8 @@ const observer = new MutationObserver((mutations) => {
return; return;
} }
const elements = mutations.flatMap((mutation) => Array.from(mutation.addedNodes)); const nodes = mutations.flatMap((mutation) => [...mutation.addedNodes]);
const elements = nodes.flatMap((node) => filterMapEarly(node));
window.dispatchEvent(new CustomEvent(triggerEventName, { detail: { elements } })); window.dispatchEvent(new CustomEvent(triggerEventName, { detail: { elements } }));
}); });
@ -456,7 +480,7 @@ window.addEventListener('pageshow', async (event) => {
}); });
/** /**
* @description Force clean when this event is fired * @description Clean DOM when this event is fired
* @listens window#cookie-dialog-monster * @listens window#cookie-dialog-monster
* @returns {void} * @returns {void}
*/ */
@ -468,17 +492,19 @@ window.addEventListener(triggerEventName, (event) => {
clean(event.detail.elements, event.detail.skipMatch); clean(event.detail.elements, event.detail.skipMatch);
} else { } else {
// 2024-08-03: look into the first level of important nodes, there are dialogs there very often // 2024-08-03: look into the first level of important nodes, there are dialogs there very often
clean([ clean(
[
...document.body.children, ...document.body.children,
...Array.from(document.getElementsByClassName('container')[0]?.children ?? []), ...[...(document.getElementsByClassName('container')[0]?.children ?? [])],
...Array.from(document.getElementsByClassName('layout')[0]?.children ?? []), ...[...(document.getElementsByClassName('layout')[0]?.children ?? [])],
...Array.from(document.getElementsByClassName('page')[0]?.children ?? []), ...[...(document.getElementsByClassName('page')[0]?.children ?? [])],
...Array.from(document.getElementsByClassName('wrapper')[0]?.children ?? []), ...[...(document.getElementsByClassName('wrapper')[0]?.children ?? [])],
...Array.from(document.getElementById('__next')?.children ?? []), ...[...(document.getElementById('__next')?.children ?? [])],
...Array.from(document.getElementById('app')?.children ?? []), ...[...(document.getElementById('app')?.children ?? [])],
...Array.from(document.getElementById('main')?.children ?? []), ...[...(document.getElementById('main')?.children ?? [])],
...Array.from(document.getElementById('root')?.children ?? []), ...[...(document.getElementById('root')?.children ?? [])],
]); ].flatMap((node) => filterMapEarly(node))
);
} }
} }
}); });